Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/chips): placeholder visible on focus #27642

Closed
wants to merge 1 commit into from

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Aug 13, 2023

prior this commit the placeholder was only visible if the chips get focused, this commit makes sure that if we have any sort of data we show our input's placeholder

fixes #26883

prior this commit the placeholder was only visible if the chips get focused, this commit makes sure that if we have any sort of data we show our input's placeholder

fixes angular#26883
// form field is focused.
.mat-mdc-chip-list-placeholder {
// stylelint-disable-next-line material/no-prefixes
.mat-mdc-chip-input::placeholder {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unsure if this was the most viable way to fix the issue cause I had to disable lint rule.

@zarend zarend added target: minor This PR is targeted for the next minor release area: material/chips dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Aug 14, 2023
@github-actions
Copy link

Deployed dev-app for 069e111 to: https://ng-dev-previews-comp--pr-angular-components-27642-43ygbkjx.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@naaajii
Copy link
Contributor Author

naaajii commented Aug 15, 2023

should we close this based on this comment?

@zarend
Copy link
Contributor

zarend commented Aug 15, 2023

Hello,

Thank you for taking initiative on this. I'm going to close this, since #26883 is closed as working-as-intended. Feel free to chime in on #26883 if you would like to discuss it further.

Here are suggestion on how to participate in this open source repository.

Best regards,

Zach

@zarend zarend closed this Aug 15, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2023
@naaajii naaajii deleted the fix-26883 branch September 27, 2024 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/chips dev-app preview When applied, previews of the dev-app are deployed to Firebase target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-bug(MatChips): Input placeholder is not showing if not focused
2 participants